Fix data corruption when creating batches.#11
Open
Wilfred wants to merge 1 commit intologstash-plugins:mainfrom
Open
Fix data corruption when creating batches.#11Wilfred wants to merge 1 commit intologstash-plugins:mainfrom
Wilfred wants to merge 1 commit intologstash-plugins:mainfrom
Conversation
Previously, we were appending events to the event collection even when
the columns did not match!
Given the following three events:
```ruby
{
"name": "my-series",
"columns": [
"cpu.user",
"time"
],
"points": [
[
5.0,
1426288467
]
]
}
{
"name": "my-series",
"columns": [
"memory.used",
"time"
],
"points": [
[
1000,
1426288467
]
]
}
{
"name": "my-series",
"columns": [
"cpu.user",
"time"
],
"points": [
[
6.0,
1426288477
]
]
}
```
We would end up with the following batch:
```ruby
[
{
"name": "my-series",
"columns": [
"cpu.user",
"time"
],
"points": [
[
5.0,
1426288467
],
[
6.0,
1426288467
]
]
},
{
"name": "my-series",
"columns": [
"memory.used",
"time"
],
"points": [
[
1000.0,
1426288467
],
[
6.0, # this shouldn't be here!
1426288467
]
]
}
]
|
I am not sure I understand this one. @Wilfred by columns do you mean inside the datapoints? |
Contributor
Author
|
Yes, inside the datapoints we're taking values from the wrong event. Does that make sense? |
|
Yes it does. |
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were appending events to the event collection even when
the columns did not match!
Given the following three events:
We would end up with the following batch: